Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Async lists loading #621

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Async lists loading #621

wants to merge 1 commit into from

Conversation

di72nn
Copy link
Member

@di72nn di72nn commented Aug 19, 2017

My second take on async loading in Android.

@ngosang
Copy link
Contributor

ngosang commented Mar 3, 2018

@di72nn Why is this important? I tested this PR in Android 7.0 and I don't notice any difference.
@Strubbl why is the development so slow? Can I help in any way?

@Strubbl
Copy link
Contributor

Strubbl commented Mar 6, 2018

async loading is interesting to include more features to the list view of the articles, e.g. adding reading time and tags to every entry.

regarding slow development: For me it is a hobby. My daily job is not Android development. I am satisfied with the current state of the app.

@di72nn
Copy link
Member Author

di72nn commented Mar 8, 2018

@ngosang
It is important because currently the app does a lot of work (e. g. DB querying) on the main thread. The difference should be noticeable on slow devices, and you can probably profile UI performance with some of the dev tools to see that the app is in trouble.
Adding new features (like tags) to the lists make the situation worth.

I'm not satisfied with the current state of the app and would like to improve it, but almost any issue requires diving into Android development peculiarities. Unfortunately, I'm not very interested in Android development and my free time is scarce now.

@ngosang
Copy link
Contributor

ngosang commented Mar 10, 2018

@Strubbl What about #671 ? It's necessary to update the @di72nn API wrapper.

@Strubbl
Copy link
Contributor

Strubbl commented Nov 19, 2019

is this one relpaced by #874 ?

@di72nn
Copy link
Member Author

di72nn commented Nov 20, 2019

Unfortunately not. #874 makes loading lighter while still doing it in the UI thread, and this one is an attempt to move loading to a background thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants